Skip to content

fix(ChatbotHeader): Remove custom styles on buttons #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ChatbotHeader): Remove custom styles on buttons #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
092b98c
fix(ChatbotHeader): Remove custom styles on buttons
rebeccaalpert Oct 30, 2026
8742b35
Fix test
rebeccaalpert Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions packages/module/src/ChatbotHeader/ChatbotHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,39 +70,6 @@
}
}

// ============================================================================
// Toggle Options
// ============================================================================
.pf-chatbot__button--toggle-options,
.pf-chatbot__button--toggle-menu {
width: 3rem;
height: 3rem;
border-radius: var(--pf-t--global--border--radius--pill);
align-items: center;
justify-content: center;

&::before {
border-radius: inherit;
}

.pf-v6-c-button__icon,
.pf-v6-c-menu-toggle__icon {
display: flex;
align-items: center;
justify-content: center;
}

// Interactive states
&:hover,
&:focus {
.pf-v6-c-button__icon,
.pf-v6-c-menu-toggle__icon,
.pf-v6-c-icon__content {
color: var(--pf-t--global--icon--color--regular);
}
}
}

// ============================================================================
// Examples
// ============================================================================
Expand Down Expand Up @@ -134,12 +101,6 @@
}
}

.pf-v6-c-menu-toggle.pf-chatbot__button--toggle-options.pf-m-compact,
.pf-chatbot__button--toggle-menu.pf-m-compact {
width: 2rem;
height: 2rem;
}

.pf-chatbot__header .pf-chatbot__actions .pf-v6-c-menu-toggle.pf-m-secondary.pf-m-compact {
width: initial;
}
5 changes: 0 additions & 5 deletions packages/module/src/ChatbotHeader/ChatbotHeaderCloseButton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,4 @@ describe('ChatbotHeaderCloseButton', () => {
fireEvent.click(screen.getByRole('button', { name: 'Close' }));
expect(onClick).toHaveBeenCalled();
});

it('should render button with isCompact', () => {
render(<ChatbotHeaderCloseButton data-testid="close-button" onClick={jest.fn()} isCompact />);
expect(screen.getByTestId('close-button')).toHaveClass('pf-m-compact');
});
});
4 changes: 2 additions & 2 deletions packages/module/src/ChatbotHeader/ChatbotHeaderCloseButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,17 @@ const ChatbotHeaderCloseButtonBase: FunctionComponent<ChatbotHeaderCloseButtonPr
{...tooltipProps}
>
<Button
className={`pf-chatbot__button--toggle-menu ${isCompact ? 'pf-m-compact' : ''}`}
variant="plain"
onClick={onClick}
aria-label={menuAriaLabel}
ref={innerRef}
icon={
<Icon size={isCompact ? 'lg' : 'xl'} isInline>
<Icon>
<RhMicronsCloseIcon />
</Icon>
}
size={isCompact ? 'sm' : undefined}
isCircle
{...props}
/>
</Tooltip>
Expand Down
3 changes: 2 additions & 1 deletion packages/module/src/ChatbotHeader/ChatbotHeaderMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,13 @@ const ChatbotHeaderMenuBase: FunctionComponent<ChatbotHeaderMenuProps> = ({
aria-label={menuAriaLabel}
ref={innerRef ?? buttonRef}
icon={
<Icon size={isCompact ? 'lg' : 'xl'} isInline>
<Icon>
<RhUiMenuBarsIcon />
</Icon>
}
size={isCompact ? 'sm' : undefined}
{...props}
isCircle
/>
),
// eslint-disable-next-line react-hooks/exhaustive-deps
Expand Down
3 changes: 2 additions & 1 deletion packages/module/src/ChatbotHeader/ChatbotHeaderOptionsDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,14 @@ export const ChatbotHeaderOptionsDropdown: FunctionComponent<ChatbotHeaderOption
aria-label={menuToggleAriaLabel}
ref={toggleRef}
icon={
<Icon size={isCompact ? 'lg' : 'xl'} isInline>
<Icon>
<RhUiEllipsisHorizontalFillIcon />
</Icon>
}
isExpanded={isOptionsMenuOpen}
onClick={() => setIsOptionsMenuOpen(!isOptionsMenuOpen)}
size={isCompact ? 'sm' : undefined}
isCircle
{...toggleProps}
/>
</Tooltip>
Expand Down
Loading