Repository navigation
Conversation
Most table options were not covered by any test. The data provider replaces testBuilderCompressed and checks that each option is rebuilt and does not consume the tokens following it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
Options not in the list were dropped when building the statement, together with all the options following them. Added options documented by MySQL and MariaDB: PAGE_CHECKSUM, TRANSACTIONAL, ENCRYPTED, ENCRYPTION_KEY_ID, ENCRYPTION, COMPRESSION, STATS_AUTO_RECALC, STATS_PERSISTENT, STATS_SAMPLE_PAGES, AUTOEXTEND_SIZE, IETF_QUOTES, SEQUENCE, ENGINE_ATTRIBUTE, SECONDARY_ENGINE_ATTRIBUTE and ADAPTIVE_HASH_INDEX. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
MariaDB quotes engine-defined table options in SHOW CREATE TABLE, e.g. `PAGE_COMPRESSED`='ON'. These were not recognized, so they were dropped together with all the options following them. phpMyAdmin rebuilds the statement when exporting the table structure, losing these options. Quoted names are only accepted where the options array enables it with `_ALLOW_QUOTED`, so quoted identifiers like SELECT `DISTINCT` are not mistaken for options. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.11.x #686 +/- ##
============================================
- Coverage 96.51% 96.50% -0.01%
+ Complexity 2352 2345 -7
============================================
Files 71 71
Lines 5187 5184 -3
============================================
- Hits 5006 5003 -3
Misses 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoted options in CREATE TABLE statement
MariaDB 11.4 quotes some options in the CREATE statement, e. g.:
SHOW CREATE TABLE t;Some missing options added
MariaDB:
PAGE_CHECKSUM
TRANSACTIONAL
ENCRYPTED
ENCRYPTION_KEY_ID
STATS_AUTO_RECALC
STATS_PERSISTENT
STATS_SAMPLE_PAGES
IETF_QUOTES
SEQUENCE
MySQL:
https://dev.mysql.com/doc/refman/8.4/en/create-table.html#create-table-options
AUTOEXTENT_SIZE
COMPRESSION
ENCRYPTION
ENGINE_ATTRIBUTE
SECONDARY_ENGINE_ATTRIBUTE
ADAPTIVE_HASH_INDEX