Repository navigation
Fix tick prefixes and suffixes with explicit tick values - #8160
Open
davrens101 wants to merge 2 commits into
Open
davrens101 wants to merge 2 commits into
davrens101 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tick prefixes and suffixes with explicit tick values
Fixes #8006.
arrayTickspassesString(undefined)as thenoSuffixPrefixflag when a tick has no explicit text. That nonempty string suppresses the prefix and suffix. Pass a boolean that tests whether explicit text exists instead. Customticktextretains its existing behavior.Regression coverage
The
axesJasmine suite covers linear, log, date, and category axes. The regression also covers partial custom text and theall,first,last, andnonedisplay modes.Prior local runs used Chrome Headless 156 on Windows:
The new regression fails before the fix and passes after the fix. Four pre-existing failures remain in each run:
should make room for the inside labels of the counter axescan relayout insiderangeshould rotate labels to avoid overlapsinsiderange react to new dataThe numerical errors match across those runs. The suite is not fully green.
The local evidence runner excludes unrelated MapLibre CSS. The installed
esbuild-plugin-inline-cssthrows atpath.resolve(undefined, args.path). No upstream configuration or dependency changes form part of this patch.These results come from the preparation logs, not a new submission-time run. Lint, typecheck, syntax, schema-drift, and full CI results are not available. No schema, public API, dependency, mock, or generated type changes occur. No local image baselines were generated. Maintainer CI must confirm the standard checks and any affected baselines.
Rendered evidence
The source-built reproduction uses
tickvals: [0, 1, 2],tickprefix: '$', andticksuffix: ' USD':The submission agent inspected the saved before/after screenshots. Screenshots and complete logs remain in the local evidence package. This CLI submission does not attach images or claim public screenshot URLs. The issue contains the original visual report.
Review and disclosure
AI assisted the patch, regression test, review, and submission. The user approved submission: "go ahead and submit it looks good to me". That approval is not a claim of independent maintainer review. 🐦
Commit
c8ecfd27a4e52229b17d598ad18243189a2f221ereplaces the placeholder withdraftlogs/8160_fix.mdand the actual PR link.