Skip to content

Fix tick prefixes and suffixes with explicit tick values - #8160

Open
davrens101 wants to merge 2 commits into
plotly:mainfrom
davrens101:fix/tickvals-prefix-suffix
Open

davrens101 wants to merge 2 commits into
plotly:mainfrom
davrens101:fix/tickvals-prefix-suffix

Conversation

@davrens101

@davrens101 davrens101 commented Nov 1, 2026 •

Copy link
Copy Markdown

Fix tick prefixes and suffixes with explicit tick values

Fixes #8006.

arrayTicks passes String(undefined) as the noSuffixPrefix flag when a tick has no explicit text. That nonempty string suppresses the prefix and suffix. Pass a boolean that tests whether explicit text exists instead. Custom ticktext retains its existing behavior.

Regression coverage

The axes Jasmine suite covers linear, log, date, and category axes. The regression also covers partial custom text and the all, first, last, and none display modes.

Prior local runs used Chrome Headless 156 on Windows:

Source, with the new regression Passed Failed Total
Pristine upstream source 398 5 403
Patched source 399 4 403

The new regression fails before the fix and passes after the fix. Four pre-existing failures remain in each run:

  • should make room for the inside labels of the counter axes
  • can relayout insiderange
  • should rotate labels to avoid overlaps
  • insiderange react to new data

The numerical errors match across those runs. The suite is not fully green.

The local evidence runner excludes unrelated MapLibre CSS. The installed esbuild-plugin-inline-css throws at path.resolve(undefined, args.path). No upstream configuration or dependency changes form part of this patch.

These results come from the preparation logs, not a new submission-time run. Lint, typecheck, syntax, schema-drift, and full CI results are not available. No schema, public API, dependency, mock, or generated type changes occur. No local image baselines were generated. Maintainer CI must confirm the standard checks and any affected baselines.

Rendered evidence

The source-built reproduction uses tickvals: [0, 1, 2], tickprefix: '$', and ticksuffix: ' USD':

Before: 0, 1, 2
After:  $0 USD, $1 USD, $2 USD

The submission agent inspected the saved before/after screenshots. Screenshots and complete logs remain in the local evidence package. This CLI submission does not attach images or claim public screenshot URLs. The issue contains the original visual report.

Review and disclosure

AI assisted the patch, regression test, review, and submission. The user approved submission: "go ahead and submit it looks good to me". That approval is not a claim of independent maintainer review. 🐦

Commit c8ecfd27a4e52229b17d598ad18243189a2f221e replaces the placeholder with draftlogs/8160_fix.md and the actual PR link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [REGRESSION]: tickprefix/ticksuffix ignored when tickvals provided

1 participant