Repository navigation
Add linecap and linejoin parameters - #603
Merged
Merged
Conversation
note that even closed polygons need linecap for dashed lines
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an entry in #530.
Briefly, most layers that use lines get the
linecapandlinejoinarguments.I chose for
linejoinspecifically becausejoinis already claimed by SQL syntax, and thenlinecapfor symmetry reasons.Only segment, rule and range do not use
linejoin, which would only apply when densified.The ribbon-based geoms populate the
cap2andjoin2from the same parameter.Plumbing in the writer sort of conflictlessly matches #597.