Repository navigation
Conversation
Assisted-by: OpenAI Codex <support@openai.com>
Member
|
Is there something in a specification that alludes to this possibility? https://github.com/syntelos/xbm/blob/master/README.txt doesn't mention anything about tabs or different kinds of whitespace. Or are there real world files that are formatted like this? Otherwise, I'm not inclined to accept a type of data purely because we once did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The line-based XBM parser introduced in #10109 reads space-separated
#definelines, but rejects definitions such as#define\ticon_width 32or#define icon_width\t32. The preceding parser accepted both spellings.Identify the directive and field name by splitting the line into tokens. Add a regression that reads an XBM with tabs in its dimensions and hotspot definitions, then checks its pixels and hotspot against the expected values.
Status of validation
git diff --checkpassed._Tiledefault. The full source build and CI matrix were not run locally.OpenAI Codex assisted with investigating the regression, preparing this patch and running the checks.