Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find
Image.point()'smodeparameter to be a bit odd. It is intended to default to the same mode as the image.Pillow/src/PIL/Image.py
Line 2050 in b8865b5
So where does that default setting apply? Partly in
_point_implPillow/src/_imaging.c
Lines 1769 to 1776 in b8865b5
and partly in
ImagingPoint().Pillow/src/libImaging/Point.c
Lines 179 to 181 in b8865b5
I think it would be simpler to set it in
_point_impl, immediately after parsing themodeparameter.