Skip to content

Pin @wordpress/env 12.1.0 for the simple-git critical advisories - #191

Open
dbutts29 wants to merge 1 commit into
masterfrom
darrenbutts/PLA-2594/2026-11-10
Open

dbutts29 wants to merge 1 commit into
masterfrom
darrenbutts/PLA-2594/2026-11-10

Conversation

@dbutts29

Copy link
Copy Markdown

Description of the change

This clears the two critical Dependabot alerts in package-lock.json, both published in October:

Both come in only through @wordpress/env. Every 11.x release depends on simple-git ^3.32.3, and no 3.x simple-git is patched. Overriding simple-git to 4.x under wp-env 11 would put a major version under a package that asks for ^3. wp-env 12 is upstream's own fix: it depends on simple-git ^4.0.2, which resolves argv-parser 2.0.1. So this pins @wordpress/env at exactly 12.1.0, up from ^11.15.0.

wp-env 12.0.0's only breaking change is raising the minimum Node version to >=22.13.0 (changelog). This workflow's ubuntu-latest runners report Node v22.23.4 (from the last run's "General debug information" step), so CI is already compatible.

After the change, npm audit shows 0 critical findings. Two existing highs (body-parser, isomorphic-git) are unchanged and out of scope.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests: n/a, dev tooling only
  • All tests related to the changed code pass in development: CI runs the PHP × WordPress matrix through wp-env 12. Locally npm ci succeeds and wp-env --version reports 12.1.0. I didn't start the Docker environment.

🤖 Generated with Claude Code

wp-env 11.x depends on simple-git ^3, and no 3.x simple-git is patched for GHSA-x6jw-m9v5-85vh / GHSA-v5rq-49vh-5v5c. wp-env 12 moves to simple-git ^4.0.2 (argv-parser 2.0.1). Its only breaking change is Node >=22.13.0; CI's ubuntu-latest runs Node 22.23.4. PLA-2594

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Nov 10, 2026

Copy link
Copy Markdown

PLA-2594

@danielmorell danielmorell self-assigned this Nov 11, 2026
@danielmorell
danielmorell self-requested a review November 11, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants