Skip to content

One Sort by strip on resources, workshops, bookmarks, org sectors, and users cards - #2981

Open
maebeale wants to merge 9 commits into
mainfrom
maebeale/sort-strip-everywhere
Open

maebeale wants to merge 9 commits into
mainfrom
maebeale/sort-strip-everywhere

Conversation

@maebeale

@maebeale maebeale commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 sort control swap on five pages plus a small reversible-sort change on the org sectors page

Resources, Workshops, My Bookmarks, the org sectors page, and the users list on small screens now share one tabbed "Sort by" strip, so sorting looks and works the same everywhere.

What

  • Every card/list index now sorts with the same segmented Sort by strip (tables still sort by column header)
    • Workshops: radio buttons → strip at the far right of the count row (same spot as resources); separate "Sort by" row removed
    • My Bookmarks: text links → strip, right-aligned; click the active option again to flip direction (arrow shows which way)
    • Org sectors & age groups: shared partial; click the active option again to reverse; labels now Primary / Total / Name so a reversed sort doesn't contradict them
    • Users (small screens): card list's text-link bar → strip, same click-again-to-flip
    • Resources: its copy from Resource kinds: limit dropdown, admin Legacy chip, sort library #2980 now renders the shared partial

How

  • New shared/_sort_strip partial, active segment filled with the domain's 700 color
    • Radio mode (inside a search form, auto-submits via the collection controller, has-checked styling, no JS)
    • Link mode (href: lambda, server marks aria-current), optional active_icon:
  • WorkshopSearchService::SORT_OPTIONS, BookmarksController::SORT_OPTIONS
  • DomainTheme gets bookmarks: :sky; Tailwind safelists has-checked:bg-{color}-700
  • docs/design/house-style.md documents the strip as the sort control for cards and lists
  • Request specs for each page; Features & tips entry
  • Fixes a flaky Resource.sorted_by spec from Resource kinds: limit dropdown, admin Legacy chip, sort library #2980 (factory's sector touch reset updated_at)

🤖 Generated with Claude Code

image image image image

@maebeale
maebeale requested a review from jmilljr24 November 11, 2026 21:38
@maebeale

Copy link
Copy Markdown
Collaborator Author

@jmilljr24 i'm consolidating all the sorts into one ui

@maebeale maebeale changed the title One Sort by strip on workshops, bookmarks, and org sectors page JM: One Sort by strip on workshops, bookmarks, and org sectors page Nov 13, 2026
@maebeale
maebeale force-pushed the maebeale/sort-strip-everywhere branch from e78c556 to 09f3f5e Compare November 19, 2026 16:30
@jmilljr24

Copy link
Copy Markdown
Collaborator

Are these the only places or do you plan more in the future?

@maebeale maebeale changed the title JM: One Sort by strip on workshops, bookmarks, and org sectors page One Sort by strip on workshops, bookmarks, org sectors, and users cards Nov 20, 2026
@maebeale
maebeale force-pushed the maebeale/sort-strip-everywhere branch from 4f4e7db to 5485d5e Compare November 20, 2026 13:23
@maebeale maebeale changed the title One Sort by strip on workshops, bookmarks, org sectors, and users cards One Sort by strip on resources, workshops, bookmarks, org sectors, and users cards Nov 20, 2026
maebeale and others added 8 commits November 20, 2026 14:52
…ors page

Shared shared/_sort_strip partial (radio mode inside search forms, link mode
otherwise). Workshops moves its radios into the count row; personal bookmarks
keeps click-again-to-flip direction with an arrow on the active segment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e strip

The users card list was the last text-link Sort by bar. House style now names
the strip as the sort control for cards and lists, so new pages reach for it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rose read as an error red on the admin-only users page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#2980 merged with its own copy; one partial keeps every strip in step.
Feature seed: admin-facing (a consistency change, not a launch), covers users,
dated to today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The factory's after(:create) sector bumps updated_at to now, so the modified
sort spec failed whenever the two creates straddled a second (CI).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Neutral labels (Primary, Total, Name) so a reversed sort doesn't contradict its
label; counts default to most-first, Name to A-Z.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maebeale
maebeale force-pushed the maebeale/sort-strip-everywhere branch from 5485d5e to 7e9b678 Compare November 20, 2026 19:54
CI's scan runs brakeman with --ensure-latest, which fails once a newer
release ships.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants