Repository navigation
Conversation
Collaborator
Author
|
@jmilljr24 i'm consolidating all the sorts into one ui |
maebeale
force-pushed
the
maebeale/sort-strip-everywhere
branch
from
November 19, 2026 16:30
e78c556 to
09f3f5e
Compare
Collaborator
|
Are these the only places or do you plan more in the future? |
maebeale
force-pushed
the
maebeale/sort-strip-everywhere
branch
from
November 20, 2026 13:23
4f4e7db to
5485d5e
Compare
…ors page Shared shared/_sort_strip partial (radio mode inside search forms, link mode otherwise). Workshops moves its radios into the count row; personal bookmarks keeps click-again-to-flip direction with an arrow on the active segment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e strip The users card list was the last text-link Sort by bar. House style now names the strip as the sort control for cards and lists, so new pages reach for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rose read as an error red on the admin-only users page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#2980 merged with its own copy; one partial keeps every strip in step. Feature seed: admin-facing (a consistency change, not a launch), covers users, dated to today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The factory's after(:create) sector bumps updated_at to now, so the modified sort spec failed whenever the two creates straddled a second (CI). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Neutral labels (Primary, Total, Name) so a reversed sort doesn't contradict its label; counts default to most-first, Name to A-Z. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/sort-strip-everywhere
branch
from
November 20, 2026 19:54
5485d5e to
7e9b678
Compare
CI's scan runs brakeman with --ensure-latest, which fails once a newer release ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 sort control swap on five pages plus a small reversible-sort change on the org sectors page
Resources, Workshops, My Bookmarks, the org sectors page, and the users list on small screens now share one tabbed "Sort by" strip, so sorting looks and works the same everywhere.
What
How
shared/_sort_strippartial, active segment filled with the domain's 700 colorhas-checkedstyling, no JS)href:lambda, server marksaria-current), optionalactive_icon:WorkshopSearchService::SORT_OPTIONS,BookmarksController::SORT_OPTIONSDomainThemegetsbookmarks: :sky; Tailwind safelistshas-checked:bg-{color}-700docs/design/house-style.mddocuments the strip as the sort control for cards and listsResource.sorted_byspec from Resource kinds: limit dropdown, admin Legacy chip, sort library #2980 (factory's sector touch resetupdated_at)🤖 Generated with Claude Code