Repository navigation
Conversation
Fourth slice of #5764. Body text, tooltips, popovers and the onboarding modal move from Source Sans Pro to the design system's Figtree, which is self-hosted (slice 1). The Google Fonts request for Source Sans Pro is gone from the three live layouts, one fewer third-party request per page. Kept apart from the colour slice because this is the one token that moves things: Figtree is wider than Source Sans Pro, so text reflows. 14 of 25 screenshotted pages change height (the partner dashboard by about 10%). Nothing else changes. Known effect, measured, not fixed here: some tables were already wider than their card on main (distributions at 1280px; items and organization at 1024px). At 1024px the wider face pushes the row-action buttons further out, and /items gains a horizontal page scrollbar. At 1280px the overflow is identical to before. This is the "tables" concept's problem, and that slice brings the design system's scrolling table container. It is worth deciding whether this lands before or after that slice. Highcharts sets its own font in its SVGs (historical trends), so charts keep theirs until the charts slice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCzWYw6Gq5YdmU4MaiGnQa
The shared "Date Range Picker" examples typed into #filters_date_range as soon as the page loaded. Litepicker seeds that field from the server's dates as the last step of its setup, so if setup finishes after the typing, the seed overwrites it and the form filters on the default range. On main the race rarely shows, because a render-blocking Google Fonts stylesheet slows every page load. Removing that request (previous commit) made pages load sooner, and with --seed 1234 spec/system/purchase_system_spec.rb failed 2-3 examples every run. Putting the font link back made them pass again, which pins the cause to the timing, not the typeface. The examples now wait for Litepicker's markup before typing (or before scripting the field), and confirm the value stuck. Ported from 6077ba5 on the design branch, which hit the same race. All 36 date range picker examples pass across six system specs under seeds 1234, 8576 and 4242. This can also land on main by itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCzWYw6Gq5YdmU4MaiGnQa
awwaiid
added a commit
that referenced
this pull request
Nov 19, 2026
docs/design-system-slicing-plan.md maps how to bring this branch to main in small pieces: one design-system concept at a time across the whole app (tokens, icons, buttons, tables, forms...), with Bootstrap and the design system on the same page in the meantime, so navigation and button placement don't change until a PR is explicitly about them. The first four slices are open as stacked draft PRs (#5765-#5768). The plan also lists fixes main needs regardless, product/IA decisions that need their own sign-off, features riding along, and what should not land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCzWYw6Gq5YdmU4MaiGnQa
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5764. Stacked draft PR 4 of 4, based on PR 3. Plan:
docs/design-system-slicing-plan.mdon thedesignbranchStack (review and merge in order; each PR shows only its own diff):
Description
Two commits.
1. Switch the typeface to Figtree. Body text, tooltips, popovers and the onboarding modal move from Source Sans Pro to the self-hosted Figtree. The Google Fonts request goes away, one fewer third-party request per page. This is the one token that moves things: Figtree is wider, so text reflows, and 14 of 25 pages change height.
main. At 1024px the wider typeface pushes them further, and/itemsgains a horizontal page scrollbar. At 1280px the overflow is the same as before. This belongs to the planned tables PR, which adds a scrolling table container. Decision for reviewers: land this before or after that PR?Highcharts sets its own font inside its SVGs, so charts keep their font for now.
2. Wait for Litepicker before typing into the date range field. Removing the render-blocking font request made pages load sooner. That exposed a race in the shared date-range-picker examples: Litepicker seeds the field after setup, which can overwrite what the test typed. Putting the font link back made the specs pass again, which pins the cause to timing, not the typeface. The examples now wait for Litepicker and check the value stuck. This is ported from 6077ba5 on the
designbranch, and can also land onmainby itself.Type of change
How Has This Been Tested?
spec/requests/storage_locations_requests_spec.rb:367and:390, which also fail on an unmodifiedmainlocally.🤖 Generated with Claude Code
https://claude.ai/code/session_01UCzWYw6Gq5YdmU4MaiGnQa