Repository navigation
[chore]: add code review rules and link them from AGENTS.md - #1481
Conversation
Add REVIEW.md with the rules automated code review should apply to pull requests in this repository, and point a Code Review Rules section in AGENTS.md at it.
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b818a22fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- Reporting: a defect the diff causes is in scope even when it shows up in a file the diff does not touch; comment on the causing diff line. - JS / TypeScript: compare return values, callback arguments, call timing and order, and error propagation against the base revision even when the signature is unchanged. - Concurrency and lifecycle: describe ordering in event-loop terms and add callbacks after unmount and late async responses.
Summary
Adds
REVIEW.mdat the repository root with the rules that automated code review should apply to pull requests in this repository, and a## Code Review Rulessection inAGENTS.mdthat points to it.Changes
REVIEW.md(new):file:linewith a concrete fix direction.AGENTS.md: adds the## Code Review Rulessection below the repository-specific marker. The rest of the file is unchanged.The rules live in their own file rather than inline in
AGENTS.md, so the general agent instructions there stay short.Backward compatibility
No public API changes — documentation only. Neither file is part of the published package (
filesinpackage.jsoncoversrelease/,dist/,LICENSE, andCHANGELOG.md).Testing
AGENTS.mdis the onlyAGENTS.mdin the repository, so no nested file takes precedence over the new section.Changelogs