Repository navigation
fix(android): insert MediaStore rows as pending on Android 10 (Samsung) - #155
Merged
Merged
Conversation
ian-wd
marked this pull request as ready for review
October 28, 2026 07:18
iBotPeaches
approved these changes
Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MediaStore.copyToMediaStorefails every time on Samsung devices running Android 10 (API 29), including 4.0.1 with #146.The library inserts a normal row, then flips it to pending with a separate
IS_PENDING=1update. On Samsung's Android 10 MediaProvider that update makes the row inaccessible to its own app:#146's
setIncludePendingdoesn't restore access: write, query, update, commit and delete all fail with both the plain and theincludePendingURI. Stock AOSP Android 10 and Android 11+ work with the old flow, which is why it doesn't reproduce on an emulator.Solution
On Android 10 only, insert the row with
IS_PENDING=1already in the insertContentValues, then write, commit (IS_PENDING=0) and clean up through the plain URI. The separate pending update is skipped. #146'ssetIncludePendingwrapping is removed.Android 11+ keeps the existing sequence,
createMediaFilestill inserts a non-pending row, and the JS API is unchanged.Verified (Firebase Test Lab)