[afonsojramos]

Summary

On Spotify 1.3.3, context menu and profile menu items that modules register were broken:

• MenuSubMenuItem was missing. The export that renders a submenu row now only switches between the v2 and legacy rows, and the subMenuIcon class it was found by is gone. It is now found through the module that renders data-context-menu-submenu-header.
• MenuItem resolved to a waveform scrubber that also mentions handleMouseEnter and onClick, so registered items rendered nothing. It now resolves to the menu item dispatcher (the export that forwards forceV2LeadingIcon), and keeps the old match as a fallback.

Testing

On Spotify 1.3.3.264 for macOS, applied with this branch:

• scripts/platform-contract.ts passes with 58 of 59 paths present. Before the fix it failed on MenuSubMenuItem. The one absent path is optional: PlatformData.os_name.
• In a track context menu, a ContextMenu.SubMenu opens on hover and its child's click handler runs. Registered top-level items, both a probe item and existing modules' items, render and respond to clicks.
• In the profile menu, a Menu.Item and a Menu.SubMenu child render and their click handlers run.
• node --test "src/jsHelper/**/*.test.mts" passes (184 tests), and pnpm typecheck is clean.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: spicetify/cli/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 75db3de2-d9fe-4958-8f81-68a0c87aec65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}