Repository navigation
fix: include gitignore files in packed plugin templates - #36
Merged
Merged
Conversation
heoblitz
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generator's source templates contain
.gitignore, butnpm packexcludes both files. Projects created from the distributed tarball therefore lack ignore rules for dependencies and build output.Store the templates as
gitignoreand restore the dot-prefixed name when generating a project. The template contents are unchanged. Add a regression test that packs and extracts the actual package, generates both plugin types, and usesgit check-ignoreto verify generated files are ignored while source files remain trackable.Changelog
Include
.gitignorein device and desktop projects created from the packaged plugin generator.Test Plan
Verified on Windows with Node.js 22.17.0 and LF template files:
.gitignoreis missing.node --test WebPackages/CreateNectoPlugin/tests/package.test.js WebPackages/CreateNectoPlugin/tests/create-project.test.js— 7 tests pass.npm --prefix WebPackages/CreateNectoPlugin test— all 16 tests pass. That fix is not included in this PR; the existing CLI tests on main still need it on Windows.npm --prefix WebPackages/CreateNectoPlugin run buildandnpm --prefix WebPackages/CreateNectoPlugin run typecheck— syntax checks pass.git diff --cached --checkpasses.macOS/iOS builds, the full release suite, and physical-device checks were not run.