Repository navigation
refactor: keep each plugin's panel, iOS and Android code in one folder - #39
Merged
heoblitz merged 1 commit intoNov 12, 2026
Merged
Conversation
The built panels lived inside the iOS source tree, and the Android build reached into it to package them. A plugin now has one folder, SDK/Plugins/<Name>, with the built panel in Panel, the Swift sources in iOS and the Gradle module in Android, so both platforms package the same directory. SDK/iOS and SDK/Android keep the bridge. Swift targets point at the plugin folder and copy Panel, which is the default directory NectoPluginPanel looks up. Gradle modules keep their names and only map to the new directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #38. The built panels lived inside the iOS source tree
(
SDK/iOS/Sources/<Module>/Panels/<id>), and the Android build reached into thattree to package them. A panel is platform neutral, so each plugin now has one
folder that holds everything it ships:
SDK/iOSandSDK/Androidkeep the bridge. Plugins without a panel(
ProcessMetric,URLSessionCapture,OkHttpCapture) move too, so every pluginis found in one place.
sources: ["iOS"]andresources: [.copy("Panel")].Panelis the directoryNectoPluginPanellooksup by default, so the plugins no longer name a subdirectory.
settings.gradle.ktsonly mapsthem to the new directories.
NectoPanelResourcestakes the panel directorybeside the module instead of searching the iOS tree.
vite.config.tsfiles build intoSDK/Plugins/<Name>/Panel.Test Plan
swift testfor the SDK package and the SDK consumer fixture pass, includingthe check that each selected plugin product provides its panel.
swift test --package-path NectoMacpasses.NectoThemeTests, which reads the panel styles from their new location, passes.node script/check-panel-assets.mjspasses.panel resources and pass their tests.
552213d55fand published all eleven modules.Not run locally, covered by this PR's CI:
script/test-android-artifactsandscript/test-android-consumer.existing build output, moved.
Not verified: