Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ labels: bug
## Environment

<!--
The connection path matters: USB device and simulator behave differently.
The connection path matters: a USB device, a simulator and an emulator behave differently.
-->

- Necto version:
- macOS version:
- Target connection: <!-- USB device / simulator / not applicable -->
- iOS version of the connected app: <!-- leave empty if no app is involved -->
- Target connection: <!-- USB device / simulator / emulator / not applicable -->
- iOS or Android version of the connected app: <!-- leave empty if no app is involved -->

## Steps to reproduce

Expand Down
63 changes: 61 additions & 2 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
retention-days: 1

sdk:
name: SDK Build & Tests
name: iOS SDK Build & Tests
if: github.server_url == 'https://github.com'
runs-on: macos-26
timeout-minutes: 30
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
retention-days: 1

e2e:
name: Simulator Connection & CLI E2E
name: iOS Simulator Connection & CLI E2E
needs: [mac, sdk]
if: github.server_url == 'https://github.com'
runs-on: macos-26
Expand Down Expand Up @@ -178,6 +178,65 @@ jobs:
SDK/Plugins/*/Android/build/reports/tests
retention-days: 7

android-e2e:
name: Android Emulator Connection E2E
if: github.server_url == 'https://github.com'
runs-on: ubuntu-24.04
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
with:
persist-credentials: false
- uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 17
cache: gradle
- name: Allow the runner to use KVM
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
- name: Install Android SDK packages
run: >
(yes || true) | $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager
"platforms;android-35" "build-tools;35.0.0" "platform-tools" "emulator"
"system-images;android-35;google_apis;x86_64"
- name: Build the Android sample
working-directory: SDK/Android
run: ./gradlew :sample:assembleDebug --console=plain
- name: Boot an emulator
env:
# avdmanager and the emulator look for AVDs in different default folders here.
ANDROID_AVD_HOME: ${{ runner.temp }}/avd
run: |
mkdir -p "$ANDROID_AVD_HOME"
echo no | $ANDROID_HOME/cmdline-tools/latest/bin/avdmanager create avd --force \
--name necto --package "system-images;android-35;google_apis;x86_64"
nohup $ANDROID_HOME/emulator/emulator -avd necto -no-window -no-audio -no-boot-anim \
-no-snapshot -gpu swiftshader_indirect > "$RUNNER_TEMP/emulator.log" 2>&1 &
adb=$ANDROID_HOME/platform-tools/adb
timeout 180 $adb wait-for-device
timeout 300 $adb shell 'until [ "$(getprop sys.boot_completed)" = 1 ]; do sleep 2; done'
$adb shell svc power stayon true
$adb shell wm dismiss-keyguard
# The Necto host runs on macOS only and hosted Mac runners cannot run an emulator,
# so this speaks to the SDK directly, the way the host does over ADB.
- name: Test the SDK connection on the emulator
run: |
script/android-sample emulator-5554 --sdk-only
script/test-android-security
- name: Upload emulator E2E results
if: always()
uses: actions/upload-artifact@v7
with:
name: android-emulator-e2e-results
path: |
Build/Android/Logs
Build/Android/security-results.json
${{ runner.temp }}/emulator.log
retention-days: 7

docs:
name: Documentation Build
if: github.server_url == 'https://github.com'
Expand Down
34 changes: 34 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,37 @@ jobs:
VERSION: ${{ inputs.version }}
RELEASE_COMMIT: ${{ needs.build.outputs.commit }}
run: node script/github-release.mjs publish "$VERSION" "$RELEASE_COMMIT"

android:
name: Android SDK on JitPack
needs: [build, publish]
runs-on: ubuntu-24.04
timeout-minutes: 30
permissions:
contents: read
env:
VERSION: ${{ inputs.version }}
steps:
- uses: actions/checkout@v7
with:
ref: ${{ needs.build.outputs.commit }}
persist-credentials: false
- uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 17
cache: gradle
- name: Install Android SDK packages
run: $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager "platforms;android-35" "build-tools;35.0.0"
# JitPack builds a tag on its first request, and the build log answers once the
# build has ended. Asking here keeps the first app that adds the release from waiting.
- name: Build the release on JitPack
run: |
curl --fail --silent --show-error --max-time 900 \
"https://jitpack.io/com/github/toss/necto/$VERSION/build.log" | tail -n 20
status="$(curl --fail --silent --show-error https://jitpack.io/api/builds/com.github.toss/necto \
| jq -r --arg version "$VERSION" '.["com.github.toss"].necto[$version]')"
echo "JitPack build of $VERSION: $status"
[[ "$status" == ok ]]
- name: Check selective consumers against JitPack
run: script/test-android-consumer --jitpack "$VERSION"
2 changes: 1 addition & 1 deletion CONTRIBUTING-ko.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Necto에 관심을 가져 주셔서 감사해요. 이슈와 풀 리퀘스트를

버그 신고나 기능 제안은 이슈로 남겨 주세요.
보안 취약점은 [보안 정책](SECURITY.md)에 따라 악용 방법이나 민감한 데이터를 공개하지 않고 문의해 주세요.
버그 리포트에는 Necto 버전, macOS 버전, 타깃 연결 방식(USB 실기기 또는 시뮬레이터), 재현 방법이 필요해요.
버그 리포트에는 Necto 버전, macOS 버전, 타깃 연결 방식(USB 실기기, 시뮬레이터 또는 에뮬레이터), 재현 방법이 필요해요.

Necto의 기능 화면은 웹 플러그인이에요. 새 기능을 제안할 때는 셸·SDK·런타임 변경에
앞서 플러그인으로 구현할 수 있는지 검토해 주세요.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ For potential vulnerabilities, follow [SECURITY.md](SECURITY.md) before posting

Use issues to report bugs or propose features. A bug report needs the Necto
version, the macOS version, how the target was connected
(USB device or simulator), and steps to reproduce.
(USB device, simulator or emulator), and steps to reproduce.

Necto's feature screens are web plugins. When proposing a feature, consider a
plugin implementation before changes to the shell, SDK or runtime.
Expand Down
Loading