Repository navigation
Preserve binary data when copying file streams - #22
Merged
Merged
Conversation
Copy the bytes returned by fread instead of treating each input chunk as a NUL-terminated string. Preserve the public stream positions and report read and write failures rather than returning success after a partial copy. Add binary boundary, current-position, native pipe error and full-device regression coverage.
troglobit
approved these changes
Nov 14, 2026
troglobit
left a comment
Owner
There was a problem hiding this comment.
Ah, nice catch, thank you! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fcopyfile()currently usesfgets()andfputs(), so an embedded NUL silently drops the rest of that input chunk. Read and write failures also return success.Copy counted bytes with
fread()/fwrite()and return an error for failed transfers, while preserving the caller's stream positions and ownership. Add binary boundary/offset tests, nonblocking-pipe read errors, an unbuffered/dev/fullwrite error, and the existing NULL-argument contract.Validation: the exact new regression fails on current master and passes with this change; GCC 13 build, focused tests, and ASan/UBSan/LeakSanitizer pass. Full
make checkpasses 21 of 22 tests; the unchangedpidfiletest fails because this environment cannot write/var/tmp, reproduced on clean master.make distcheckincludes and passes the new test, then hits the same existingpidfilerestriction. Native Clang, Debian packaging and other operating systems were not tested locally. Buffered flush errors remain the caller's responsibility.