Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fsendfile()treats a failedfread()like EOF and returns a successful byte count, including when a nonblocking pipe has no data or runs out after a partial transfer. This contradicts its documented-1error return and affects both copying and the supported discard mode.Check the source stream's error indicator and preserve
errnoacross buffer cleanup. Keep copied bytes and caller ownership of both streams intact, so callers can clear the source error and resume.Validation: the new real-pipe regression fails on current master and passes with the fix. It covers initial/partial read errors with finite/unlimited lengths, copy/discard modes and clear-error reuse; controls cover exact-length reads without EOF, binary data across buffer boundaries, stream offsets, EOF, invalid arguments and an unbuffered
/dev/fullwrite failure. Strict GCC and ASan/UBSan/LeakSanitizer checks pass. GCC 13 full build passes. Fullmake checkpasses 23 of 24 tests;pidfilecannot write/var/tmphere, reproduced using the exact current master test and dependencies.make distcheckincludes and passes the new regression, then hits the same limitation; native Clang, Debian packaging and other operating systems were not tested locally. Buffered destination flush errors remain the caller's responsibility.