Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writesf()ignores an immediatefprintf()error and returns onlyfclose()'s result. A large write to/dev/full, or a write through the supported mode argument opened as read-only, can therefore return success after no data was written.Return the original write error while still closing the stream. Deferred buffered-write errors continue to come from
fclose().Validation: the new regression fails on current master and passes with this change. It exercises read-only output, short and large
/dev/fullwrites across buffer boundaries, descriptor reuse after repeated errors, normal multiline writes, append/truncate modes, empty strings, formatted paths, existing reader helpers, and open failures. Strict GCC and ASan/UBSan/LeakSanitizer checks pass. GCC 13 full build passes. Fullmake checkpasses 23 of 24 tests;pidfilecannot write/var/tmphere, reproduced using the exact current master test and dependencies.make distcheckincludes and passes the new regression, then hits the same limitation; native Clang, Debian packaging, actual proc/sys device writes and other operating systems were not tested locally.