Repository navigation
fix: preserve native-unit bigint timestamp inputs - #79
Merged
Merged
Conversation
jheer
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building a second-, microsecond-, or nanosecond-resolution timestamp column from bigint values currently throws because the converter mixes bigint inputs with number arithmetic. This change stores bigint inputs in the column's native unit, making values extracted with
useBigIntTimestampusable as inputs without losing sub-millisecond precision. Number and Date inputs continue to represent milliseconds.The implementation changes only timestamp conversion and documents the input units. Tests cover all four units, signed int64 boundaries, nulls, mixed inputs, typed arrays, iterables, multiple batches, timezone preservation, default extraction, and IPC stream/file round trips. Apache Arrow JS independently verifies the encoded int64 buffers.
Validation: