Skip to content

fix: repair broken Svelte and Playwright links - #14797

Merged
ArmandPhilippot merged 2 commits into
withastro:mainfrom
A-G0D:fix/broken-svelte-playwright-links
Oct 28, 2026
Merged

ArmandPhilippot merged 2 commits into
withastro:mainfrom
A-G0D:fix/broken-svelte-playwright-links

Conversation

@A-G0D

@A-G0D A-G0D commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

What this fixes

Two external links in the English docs point at pages that now return HTTP 404:

  • src/content/docs/en/recipes/sharing-state-islands.mdx links to https://svelte.dev/tutorial/writable-stores in three places. The Svelte tutorial was reorganized and that URL 404s.
  • src/content/docs/en/guides/testing.mdx links to https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests for the webServer option. That page 404s; Playwright now documents the option at /docs/test-webserver.

Repro (before)

Verified on 2026-10-28 with:

curl -sL -A "Mozilla/5.0 ..." -o /dev/null -w '%{http_code}' <url>

404  https://svelte.dev/tutorial/writable-stores
404  https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests

Fix

  • All three Svelte stores links now point to https://svelte.dev/docs/svelte/stores (200).
  • The Playwright webServer link now points to https://playwright.dev/docs/test-webserver (200).

Both replacements were re-checked after editing and return 200.

Verification

  • curl -sL ... -o /dev/null -w '%{http_code}' → 200 for both new targets; old targets remain 404.
  • pnpm exec prettier --check <the two changed files> → All matched files use Prettier code style! (note: .prettierignore excludes *.mdx in this repo, so these pages are outside Prettier's input set).
  • git diff --check → no whitespace errors.

Docs-only change: four URLs in two English pages. No prose, code, or translation files changed, and (en-only) keeps the translation status tracker from being triggered.

Risk / rollback

Tiny docs-only diff; reverting restores the previous URLs.

AI assistance: prepared with an AI coding agent; I reviewed and ran the checks above.

@github-actions github-actions Bot added the recipe Best solved by creating a short how-to/example label Oct 28, 2026
@astrobot-houston

Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. Once a maintainer approves our workflows, you’ll be able to see a preview of your changes on Cloudflare 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston

astrobot-houston commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the tracking.ignoredKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
guides/testing.mdx Source changed, localizations will be marked as outdated.
recipes/sharing-state-islands.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ArmandPhilippot ArmandPhilippot added the typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. label Oct 28, 2026
@ArmandPhilippot ArmandPhilippot changed the title fix: repair broken Svelte and Playwright links (en-only) fix: repair broken Svelte and Playwright links Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

@ArmandPhilippot ArmandPhilippot left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

Docs-only change: four URLs in two English pages. No prose, code, or translation files changed, and (en-only) keeps the translation status tracker from being triggered.

Except we want the links to be fixed in the translations as well, so I updated the PR title to remove (en-only) .

@ArmandPhilippot
ArmandPhilippot merged commit 8850dcf into withastro:main Oct 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recipe Best solved by creating a short how-to/example typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants