Repository navigation
echoserver: wipe and bound the key load buffer - #1340
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1340
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
8524957 to
1d062a9
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1340
Scan targets checked: none
Unchanged since last review (not re-run): wolfssh-src, wolfssh-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
keyLoadBuf held host private keys but was wiped only under WOLFSSH_SMALL_STACK. KeyLoadBufFree() now wipes it in every build and frees it only when it came from the heap. - Route every keyLoadBuf exit through KeyLoadBufFree() - Wipe the ML-DSA key buffer in LoadMlDsaHostKeys() before each free Issue: F-8859, F-10605
1d062a9 to
d50fb15
Compare
|
All Tests Successfully Launched. |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1340
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Max
d50fb15 to
f664425
Compare
LoadPublicKeyBuffer() searches for its delimiters only up to the end of the buffer, so a -j file without a final newline is rejected instead of read past. The sample password, public key, and none lists are copied into keyLoadBuf only when they fit. - Add FindDelimiter() in place of the unbounded WSTRCHR() calls - Add CopyToKeyLoadBuf(), which refuses a string with no room for its terminator and still accepts an empty one - Parse a -j file by the bytes actually read, and stop when the read fails - Warn when a -j file's keys are not all loaded - Fix the comment claiming every sample key is ssh-rsa Issue: F-10600, F-10565, F-14765
f664425 to
21165dd
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1340
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
The echoserver's key load buffer held host private keys but was wiped
only in small-stack builds, and the key list parse could read past it.
buffer is wiped before each free.
Issue: F-8859, F-10605, F-10600, F-10565, F-14765