Repository navigation
fix: fail fast mac notarization agreement preflight - #411
Merged
Merged
Conversation
WalkthroughWarning Review details and warnings were omitted to fit the comment limit. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
elkaix
marked this pull request as ready for review
November 14, 2026 04:23
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement or Bug
The
Desktop Releaseworkflowmacjob failed late duringelectron-buildernotarization with Apple HTTP 403 (required agreement is missing or expired). This change makes the job fail early with a clear preflight error before packaging work starts.Bug Reproduction Steps
.github/workflows/desktop-release.ymlwith mac signing + notarization credentials configured.pnpm exec electron-builder --mac dmg zip --publish neverwithFailed to notarize via notarytooland HTTP 403.Root Cause
The workflow validated credential presence, but it did not validate Apple notary service access before packaging/signing.
Result: the job spent minutes building/signing, then failed at notarization.
This is a fundamental fix (preflight gate), not a workaround.
Code Changes
Workflow preflight gate
.github/workflows/desktop-release.yml.xcrun notarytoolcredential validation and fails immediately on agreement/authorization errors.Test coverage update
electron-builder.Example snippet:
Behavior Changes and Affected Users
electron-buildernotarization after build/sign workAffected modules and test coverage:
.github/workflows/desktop-release.yml— covered byapps/desktop/tests/desktop-release-workflow.spec.tsassertions for mac workflow gates.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.