Repository navigation
feat: Add server_tenancy parameter to Actor create and update - #1169
Conversation
janbuchar
added
adhoc
apify-service-account
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
- Coverage 95.74% 95.74% -0.01%
==========================================
Files 63 63
Lines 6678 6668 -10
==========================================
- Hits 6394 6384 -10
Misses 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apify-factory
left a comment
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a human review is active (vdusek: CHANGES_REQUESTED).
| check | result |
|---|---|
| Static gates | ✅ 16/16 |
| Review findings | ✅ none |
| Reviewer escalation | ❌ Adds a new public keyword argument to the exported ActorClient.update and ActorCollectionClient.create signatures (public contract change). |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — the reviewer escalated |
Why it was not auto-approved
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 805bcc746 · workflow run
…1202) Renames the `actor_standby_*` arguments of `ActorClient.update`, `ActorCollectionClient.create`, `TaskClient.update`, and `TaskCollectionClient.create` (sync and async) to the Server Actor naming used by `ActorClient.server()`: | Deprecated | New | | --- | --- | | `actor_standby_is_enabled` | `server_is_enabled` | | `actor_standby_desired_requests_per_actor_run` | `server_desired_requests_per_actor_run` | | `actor_standby_max_requests_per_actor_run` | `server_max_requests_per_actor_run` | | `actor_standby_idle_timeout` | `server_idle_timeout` | | `actor_standby_build` | `server_build` | | `actor_standby_memory_mbytes` | `server_memory_mbytes` | | `actor_standby_disable_standby_fields_override` | `server_disable_fields_override` | | `actor_standby_should_pass_actor_input` | `server_should_pass_actor_input` | The task methods take the five arguments they had before. The old names stay as deprecated aliases until v4, the same way as `build_tag` in `validate_input()`. Each one set emits a `DeprecationWarning` at the caller, and passing an alias together with its new name raises a `ValueError`. All eight methods share one helper, `build_actor_standby`, which maps the aliases and builds the `actorStandby` field. `actor_standby_tenancy` from #1169 isn't on master yet, so it isn't covered here. #1169 can add it as `server_tenancy` directly, without an alias. It should ship in the same release as #1153. Closes: #1195 *✍️ Drafted by Claude Code*
| class ActorNotice(Enum): | ||
| """A warning displayed on the Actor's page in Apify Store and Console. Can be set by the Actor's developer or automatically by Apify's quality checks.""" | ||
|
|
||
| NONE = 'NONE' |
There was a problem hiding this comment.
This is weird, but https://github.com/apify/apify-core/issues/29871
| ) | ||
|
|
||
|
|
||
| MonitoringLevel = Literal['STANDARD',] | str |
There was a problem hiding this comment.
Can we change the generator to skip the trailing comma when there's only one value (Literal['STANDARD'] | str)?
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Could you change the PR title to say what was added? For example:
"feat: Add server_tenancy parameter to Actor create and update".
"Add missing params" doesn't tell users much, and it's just one parameter anyway.
Also one more note note regarding the generation of literals. Up to you whether/how to resolve it.
Otherwise LGTM.
janbuchar
changed the title
server_tenancy parameter to Actor create and update
No description provided.