Repository navigation
Don't lose a component's breakpoints when single-stepping is turned off - #15182
Merged
Merged
Conversation
A component's core modules share one code image and frame table, so each module re-patched every module's breakpoint sites by its own breakpoints, and the last one decided for all.
sansmoraxz
force-pushed
the
guest_debug_fix
branch
from
November 6, 2026 20:27
3bf0aff to
3c0a67c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a component with several core modules, turning single-stepping off removed the breakpoints in all of its modules except the last one.
The modules share one code image. When single-stepping was switched, each module reset every breakpoint site in that shared code by its own list of breakpoints, including the sites belonging to other modules. Whichever module went last decided for all of them.
With this change, each module only resets its own sites.
The test,
component_breakpoint_survives_single_step, sets a breakpoint in one of two modules, turns single-stepping on and off, and checks that the breakpoint still fires. Without the fix, a breakpoint in the first module never fires.