Skip to content

fix: improve gap cursor usage - #9552

Merged
mejo- merged 2 commits into
mainfrom
fix/gap_cursor
Nov 5, 2026
Merged

mejo- merged 2 commits into
mainfrom
fix/gap_cursor

Conversation

@mejo-

@mejo- mejo- commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

📝 Summary

Allows to place gap cursor between block nodes (e.g. two tables or a table and image), and make gap cursor visible in dark mode.

See commit messages for details.

  • fix(gapcursor): visibility in dark mode and padding
  • fix(gapcursor): fix gap cursor between block nodes

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

mejo- added 2 commits November 5, 2026 10:29
Make sure the gap cursor is visible in dark mode and fix its padding so
the content doesn't jump when gap cursor is displayed.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
The gap cursor plugin accepts a position only if the parent's content
match at that index has a textblock as its default type. A we set
`block+ comments? footnotes?` as content for the Document node, the
content match after first block lists footnotes first. Therefore we have
to explicitely allow gapcursor for the Documents node.

Also leave a gap before tables for the gap cursor so it's possible to
navigate the cursor between two tables with the mouse.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo- mejo- self-assigned this Nov 5, 2026
@mejo- mejo- added bug Something isn't working 3. to review labels Nov 5, 2026
@mejo- mejo- added the ux label Nov 5, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 5, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 5, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Productivity team Nov 5, 2026
@mejo- mejo- moved this from 🏗️ In progress to 👀 In review in 📝 Productivity team Nov 5, 2026
@mejo-

mejo- commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

@mejo-

mejo- commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@mejo-
mejo- merged commit a76939b into main Nov 5, 2026
63 of 65 checks passed
@mejo-
mejo- deleted the fix/gap_cursor branch November 5, 2026 12:10
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits bug Something isn't working ux

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants