Repository navigation
fix: improve gap cursor usage - #9552
Merged
Merged
Conversation
Make sure the gap cursor is visible in dark mode and fix its padding so the content doesn't jump when gap cursor is displayed. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
The gap cursor plugin accepts a position only if the parent's content match at that index has a textblock as its default type. A we set `block+ comments? footnotes?` as content for the Document node, the content match after first block lists footnotes first. Therefore we have to explicitely allow gapcursor for the Documents node. Also leave a gap before tables for the gap cursor so it's possible to navigate the cursor between two tables with the mouse. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
benjaminfrueh
approved these changes
Nov 5, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Allows to place gap cursor between block nodes (e.g. two tables or a table and image), and make gap cursor visible in dark mode.
See commit messages for details.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)