Repository navigation
Adding Continuous Acquisition Chart Multiple Samples example in NI-DMM - #2220
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2220 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 88 88
Lines 22830 22830
=======================================
+ Hits 20118 20119 +1
+ Misses 2712 2711 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The plotting approach in this example follows the existing gRPC Device Server example continuous-acquire-graph-multiple-points.py , which displays the continuous data with matplotlib. |
|
@jarnoldNI, the PR is ready for your review. |
Can you post a screenshot of what the plot looks like? |
Thanks for pointing that out. I've attached screenshots of the plot below with additional details for clarity: Screenshot 1: Shows the plot generated with Python example. Please let me know if there's any other information you'd like me to include.
|
|
@ni-jfitzger, I’ve addressed the comments you mentioned. Could you please take a look and let me know if you have any additional suggestions? |
marcoskirsch
left a comment
There was a problem hiding this comment.
I do not think this is an appropriate example. Examples should teach clients how to use the driver API, not how to use a third party plotting library.
@marcoskirsch Agreed. I removed the plotting code, so the example now only uses the |
I do not think this is an appropriate example. Examples should teach clients how to use the driver API, not how to use a third party plotting library.
This has been addressed.


- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR adds
nidmm_cont_acq_chart_multiple_samples.py, a Python adaptation of the LabVIEWCont Acq & Chart Multiple Samples.viWhat testing has been done?