Skip to content

Adding Continuous Acquisition Chart Multiple Samples example in NI-DMM - #2220

Merged
ni-jfitzger merged 26 commits into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-nidmm-cont-acq-chart-multiple-samples
Nov 4, 2026
Merged

ni-jfitzger merged 26 commits into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-nidmm-cont-acq-chart-multiple-samples

Conversation

@NI-velmurugan

@NI-velmurugan NI-velmurugan commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
    - [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR adds nidmm_cont_acq_chart_multiple_samples.py, a Python adaptation of the LabVIEW Cont Acq & Chart Multiple Samples.vi

What testing has been done?

  • Manually tested the example using simulated hardware and the real hardware

@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (9b70885) to head (06d7239).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2220   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          88       88           
  Lines       22830    22830           
=======================================
+ Hits        20118    20119    +1     
+ Misses       2712     2711    -1     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.40% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.71% <ø> (ø)
nirfsaunittests 63.37% <ø> (ø)
nirfsgsystemtests 81.22% <ø> (ø)
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NI-velmurugan

Copy link
Copy Markdown
Contributor Author

The plotting approach in this example follows the existing gRPC Device Server example continuous-acquire-graph-multiple-points.py , which displays the continuous data with matplotlib.

@divakar-selvam07

Copy link
Copy Markdown
Contributor

@jarnoldNI, the PR is ready for your review.

@NI-velmurugan NI-velmurugan changed the title feat: add nidmm cont acq chart multiple samples example Adding Continuous Acquisition Chart Multiple Samples example in NI-DMM Oct 12, 2026
@NI-velmurugan
NI-velmurugan marked this pull request as ready for review October 14, 2026 04:54
@ni-jfitzger

ni-jfitzger commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

The plotting approach in this example follows the existing gRPC Device Server example continuous-acquire-graph-multiple-points.py , which displays the continuous data with matplotlib.

Can you post a screenshot of what the plot looks like?

@NI-velmurugan

Copy link
Copy Markdown
Contributor Author

The plotting approach in this example follows the existing gRPC Device Server example continuous-acquire-graph-multiple-points.py , which displays the continuous data with matplotlib.

Can you post a screenshot of what the plot looks like?

Thanks for pointing that out. I've attached screenshots of the plot below with additional details for clarity:

Screenshot 1: Shows the plot generated with Python example.
Screenshot 2: Shows the plot generated with LabVIEW.

Please let me know if there's any other information you'd like me to include.

image image

@NI-velmurugan

Copy link
Copy Markdown
Contributor Author

@ni-jfitzger, I’ve addressed the comments you mentioned. Could you please take a look and let me know if you have any additional suggestions?

@marcoskirsch marcoskirsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is an appropriate example. Examples should teach clients how to use the driver API, not how to use a third party plotting library.

@NI-velmurugan

NI-velmurugan commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

I do not think this is an appropriate example. Examples should teach clients how to use the driver API, not how to use a third party plotting library.

@marcoskirsch Agreed. I removed the plotting code, so the example now only uses the nidmm API.

@ni-jfitzger
ni-jfitzger dismissed marcoskirsch’s stale review November 4, 2026 16:00

I do not think this is an appropriate example. Examples should teach clients how to use the driver API, not how to use a third party plotting library.

This has been addressed.

@ni-jfitzger
ni-jfitzger merged commit 72c2856 into ni:master Nov 4, 2026
49 checks passed
@divakar-selvam07
divakar-selvam07 deleted the users/velmurugan/add-nidmm-cont-acq-chart-multiple-samples branch November 4, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants