Skip to content

Additional tests - #185

Closed
ElioPalleschi wants to merge 35 commits into
pulp-platform:mainfrom
FondazioneChipsIT:epalleschi/vfu_and_vlsu_additions
Closed

ElioPalleschi wants to merge 35 commits into
pulp-platform:mainfrom
FondazioneChipsIT:epalleschi/vfu_and_vlsu_additions

Conversation

@ElioPalleschi

Copy link
Copy Markdown
Contributor

This pull request introduces support for register load/store instructions with the related tests, and additional tests for other instructions.

This PR is related to this vpu.

Hardware support for new vector instructions

Added support for whole register group load instructions (VL1RE8/16/32/64, VL2RE8/16/32/64, VL4RE8/16/32/64, VL8RE8/16/32/64) and corresponding store instructions (VS1R, VS2R, VS4R, VS8R) in the main Snitch core module (snitch.sv).

Added tests
Added tests for vfredosum, vmv, vadc, vmadc, vsbc, vmsbc, vlre and vsr.

@ElioPalleschi
ElioPalleschi marked this pull request as ready for review October 29, 2026 09:51
Copilot AI balanced review requested due to automatic review settings October 29, 2026 09:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

rgiunti
rgiunti previously approved these changes Oct 29, 2026

@rgiunti rgiunti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Navaneeth-KunhiPurayil could you start the CI for this PR? Thanks

rgiunti
rgiunti previously approved these changes Oct 29, 2026
@ElioPalleschi
ElioPalleschi force-pushed the epalleschi/vfu_and_vlsu_additions branch from c40b8b1 to 6dd8d4c Compare November 5, 2026 15:45
@rgiunti
rgiunti self-requested a review November 5, 2026 15:47
rgiunti
rgiunti previously approved these changes Nov 5, 2026
@rgiunti

rgiunti commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Hi @DiyouS, could you trigger the CI for this PR? Thanks

@rgiunti
rgiunti requested a review from DiyouS November 5, 2026 15:49
@ElioPalleschi

Copy link
Copy Markdown
Contributor Author

Hi @DiyouS, can you start the CI please?

@DiyouS

DiyouS commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Hi @DiyouS, can you start the CI please?

Done

@ElioPalleschi
ElioPalleschi deleted the epalleschi/vfu_and_vlsu_additions branch November 12, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants