Repository navigation
test: resolve generator CLI file URL as a native path - #35
Merged
Merged
Conversation
heoblitz
approved these changes
Nov 12, 2026
heoblitz
left a comment
heoblitz
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generator CLI tests pass
cli.pathnameto Node, but a file URL pathname is not a native filesystem path. On Windows it produces a path such asC:\C:\...and all nine CLI tests fail withMODULE_NOT_FOUNDbefore reaching the CLI. URL pathnames also retain percent-encoded spaces and non-ASCII characters.Use
fileURLToPath(cli)when spawning the CLI, matching the file URL handling already used in the generator implementation. This changes only the test helper.Test Plan
Verified on Windows with Node.js 22.17.0:
node --test WebPackages/CreateNectoPlugin/tests/cli.test.js— all 9 CLI tests fail with the invalid path.npm --prefix WebPackages/CreateNectoPlugin test— all 13 tests pass.node --test tests/cli.test.js tests/create-project.test.js— all 13 tests pass in each directory.npm --prefix WebPackages/CreateNectoPlugin run buildandnpm --prefix WebPackages/CreateNectoPlugin run typecheck— the package's syntax checks pass.git diff --checkpasses.macOS/iOS builds, Swift tests, and device/USB checks were not run. The application and SDK are unchanged.